Allow undated reconstructed events

server/api.integration.test.ts

@@ -140,6 +140,21 @@ suite('level persistence API', () => {
       metadata: { witness: 'Integration test', confidence: 'high' },
     })
 
+    const undatedState = structuredClone(afterMetadataSave)
+    const undatedEvent = undatedState.evidence.find(exhibit => exhibit.id === eventId)!
+    delete undatedEvent.eventDate
+    const undatedSave = await fetch(`${baseUrl}/api/levels/${state.id}?edit=1`, {
+      method: 'PUT', headers: { 'content-type': 'application/json' }, body: JSON.stringify(undatedState),
+    })
+    expect(undatedSave.ok).toBe(true)
+    const loadedUndated = await (await fetch(`${baseUrl}/api/levels/${state.id}?edit=1`)).json() as CaseState
+    expect(loadedUndated.evidence.find(exhibit => exhibit.id === eventId)?.eventDate).toBeUndefined()
+    expect((await appPool.query<{ occurred_at: Date | null }>('SELECT occurred_at FROM osint.event_exhibits WHERE exhibit_id=$1', [eventId])).rows[0].occurred_at).toBeNull()
+    loadedUndated.evidence.find(exhibit => exhibit.id === eventId)!.eventDate = '2021-04-18T14:30:00Z'
+    expect((await fetch(`${baseUrl}/api/levels/${state.id}?edit=1`, {
+      method: 'PUT', headers: { 'content-type': 'application/json' }, body: JSON.stringify(loadedUndated),
+    })).ok).toBe(true)
+
     const playerState = await (await fetch(`${baseUrl}/api/levels/${state.id}`)).json() as CaseState
     expect(playerState.brief.concepts.every(concept => concept.expectedPartyKind === undefined)).toBe(true)
     const personPartyId = randomUUID()

server/boardClone.ts

@@ -68,7 +68,7 @@ export async function cloneBoard(client: PoolClient, sourceBoardId: string, targ
   for (const row of notes.rows) await client.query('INSERT INTO osint.note_exhibits (exhibit_id,title,note_text) VALUES ($1,$2,$3)',
     [mapped(exhibitIds, row.exhibit_id, 'note'), row.title, row.note_text])
 
-  const events = await client.query<{ exhibit_id: string; title: string; narrative_text: string; occurred_at: Date }>(
+  const events = await client.query<{ exhibit_id: string; title: string; narrative_text: string; occurred_at: Date | null }>(
     `SELECT ev.* FROM osint.event_exhibits ev JOIN osint.exhibits e ON e.id=ev.exhibit_id WHERE e.board_id=$1`, [sourceBoardId])
   for (const row of events.rows) await client.query(
     'INSERT INTO osint.event_exhibits (exhibit_id,title,narrative_text,occurred_at) VALUES ($1,$2,$3,$4)',

server/levelRepository.ts

@@ -247,7 +247,7 @@ export function createLevelRepository(pool: Pool, editingEnabled: boolean): Leve
       if (canonicalType === 'note') await client.query('INSERT INTO osint.note_exhibits (exhibit_id,title,note_text) VALUES ($1,$2,$3)', [exhibit.id, exhibit.title, exhibit.content])
       if (canonicalType === 'event') await client.query(
         'INSERT INTO osint.event_exhibits (exhibit_id,title,narrative_text,occurred_at) VALUES ($1,$2,$3,$4)',
-        [exhibit.id, exhibit.title, exhibit.content, timestamp(exhibit.eventDate) || new Date().toISOString()])
+        [exhibit.id, exhibit.title, exhibit.content, timestamp(exhibit.eventDate)])
       if (canonicalType === 'party') {
         const partyKind: PartyKind = exhibit.partyKind === 'organization' ? 'organization' : 'person'
         await client.query('INSERT INTO osint.party_exhibits (exhibit_id,party_kind,display_name,summary) VALUES ($1,$2,$3,$4)',

server/migrations.integration.test.ts

@@ -33,7 +33,7 @@ suite('PostgreSQL migrations', () => {
     const migrationsDir = path.resolve(path.dirname(fileURLToPath(import.meta.url)), '..', 'migrations')
     const firstRun: string[] = []
     await runMigrations(testDatabaseUrl, migrationsDir, message => firstRun.push(message))
-    expect(firstRun.filter(message => message.startsWith('apply '))).toHaveLength(11)
+    expect(firstRun.filter(message => message.startsWith('apply '))).toHaveLength(12)
 
     const client = new Client({ connectionString: testDatabaseUrl })
     await client.connect()
@@ -47,14 +47,16 @@ suite('PostgreSQL migrations', () => {
     ]))
     expect(tableNames).not.toEqual(expect.arrayContaining(['cases', 'widgets', 'widget_relations', 'playthroughs']))
     const ledger = await client.query<{ count: string }>('SELECT COUNT(*)::text AS count FROM osint.schema_migrations')
-    expect(ledger.rows[0].count).toBe('11')
+    expect(ledger.rows[0].count).toBe('12')
     const connectionColumns = await client.query<{ column_name: string }>(`SELECT column_name FROM information_schema.columns WHERE table_schema='osint' AND table_name='exhibit_connections'`)
     expect(connectionColumns.rows.map(row => row.column_name)).toEqual(expect.arrayContaining(['label', 'tightness', 'tag_style', 'tag_position_percent', 'tag_lateral_offset']))
+    const eventOccurrence = await client.query<{ is_nullable: string }>(`SELECT is_nullable FROM information_schema.columns WHERE table_schema='osint' AND table_name='event_exhibits' AND column_name='occurred_at'`)
+    expect(eventOccurrence.rows[0].is_nullable).toBe('YES')
     await client.end()
 
     const secondRun: string[] = []
     await runMigrations(testDatabaseUrl, migrationsDir, message => secondRun.push(message))
-    expect(secondRun.filter(message => message.startsWith('skip  '))).toHaveLength(11)
+    expect(secondRun.filter(message => message.startsWith('skip  '))).toHaveLength(12)
     expect(secondRun.some(message => message.startsWith('apply '))).toBe(false)
   })
 })